solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Use config.assets.prefix for asset paths in a spec #370

Closed fenec closed 2 weeks ago

fenec commented 3 weeks ago

Summary

Sometimes, assets path differ from /assets, so it's better not to hardcode it in tests. Using Rails.application.config.assets.prefix instead

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.00%. Comparing base (8e003e7) to head (8d8afda). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #370 +/- ## ======================================= Coverage 95.99% 96.00% ======================================= Files 207 207 Lines 4874 4876 +2 ======================================= + Hits 4679 4681 +2 Misses 195 195 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kennyadsl commented 2 weeks ago

Thanks @fenec!