search

solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
Other
58 stars 40 forks source link

Add Rails 7.2 support #374

Closed tvdeyen closed 1 week ago

tvdeyen commented 1 month ago

For now we need the master branch of canonical-rails and my solidus fork with the rails-7.2 branch.

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.97%. Comparing base (42ef9cc) to head (141173d). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #374 +/- ## ========================================== - Coverage 95.98% 95.97% -0.01% ========================================== Files 207 207 Lines 4878 4866 -12 ========================================== - Hits 4682 4670 -12 Misses 196 196 ``` | [Flag](https://app.codecov.io/gh/solidusio/solidus_starter_frontend/pull/374/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solidusio) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/solidusio/solidus_starter_frontend/pull/374/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solidusio) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solidusio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tvdeyen commented 3 weeks ago

We need this for https://github.com/solidusio/solidus/pull/5843 but it only will pass tests if we also merge the solidus PR. I think we should merge this first and then allow it to fail until we also merge the solidus PR /c @solidusio/core-team

kennyadsl commented 1 week ago

@tvdeyen this is not needed anymore?

tvdeyen commented 1 week ago

@tvdeyen this is not needed anymore?

Not sure. It adds specs for Rails 7.2

fthobe commented 1 week ago

@tvdeyen can be closed at this point or not?