solidusio / solidus_stripe

💳 Integrate Solidus with Stripe
https://stripe.com
BSD 3-Clause "New" or "Revised" License
36 stars 61 forks source link

Update Stripe when a payment is failed on Solidus part #185

Closed waiting-for-dev closed 1 year ago

waiting-for-dev commented 1 year ago

Steps to reproduce

Result Stripe authorizes the payment, while Solidus shows an error message because of trying to move a failed payment forward.

Expected result Stripe has already marked that payment as invalid and we get the appropriate response.

Considerations It's not a very likely scenario, as just after the form is submitted in a normal flow, the payment will be marked as :pending, and the transition to :failure won't be possible anymore.

rainerdema commented 1 year ago

With the introduction of #249, we will no longer have a payment in the payment step but in the confirm one. This payment will be in checkout state with no available actions for the admin.

https://user-images.githubusercontent.com/19948291/228614814-39bdf836-d42f-4f65-99b1-378740e8630d.mov

waiting-for-dev commented 1 year ago

Cool, @rainerdema! Does it mean we can close this one?

rainerdema commented 1 year ago

Cool, @rainerdema! Does it mean we can close this one?

Yeah I think so 👍 I'm waiting to merge #249 before closing this one