search

solidusio / solidus_stripe

💳 Integrate Solidus with Stripe
https://stripe.com
BSD 3-Clause "New" or "Revised" License
36 stars 62 forks source link

Ensure we either really only have a single stripe "in progress" payment for each order #201

Closed elia closed 1 year ago

elia commented 1 year ago

From my tests here it seems like the intent you create during create_in_progress_payment_for(order) has always the status 'requires_source' (waiting to enter card details, I understand). So if you run multiple times find_or_create_in_progress_payment_for it will always recreate a payment + payment intent because you nulify the payment on this line. I think that's not what we want, we should void recreating intents whenever possible. What is the purpose of this line exactly ?

_Originally posted by @loicginoux in https://github.com/solidusio/solidus_stripe/pull/158#discussion_r1117888520_

elia commented 1 year ago

Not needed anymore, we shifted to having a dedicated payment_intents table joining orders with remote payment intents (same for setup intents).