solidusio / solidus_stripe

💳 Integrate Solidus with Stripe
https://stripe.com
BSD 3-Clause "New" or "Revised" License
36 stars 61 forks source link

Merge intent controller actions #241

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

Merge the two actions in the intent controller, they follow mostly the same behavior with a single deviation depending on the type of intent.

Ref #210

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

elia commented 1 year ago

For later, does add_to_wallet seem like something that could belong to the strategy class?

@kennyadsl we could only if we rely on it for deciding which kind of intent we expect, instead of reacting to the presence of the param (e.g. param[:payment_intent]).

elia commented 1 year ago

Merging, since the failure is related to the starter frontend and is already being fixed by @rainerdema 🙌