Refactor the stimulus controller - Githubissues

solidusio / solidus_stripe

💳 Integrate Solidus with Stripe

https://stripe.com

BSD 3-Clause "New" or "Revised" License

36 stars 62 forks source link

Refactor the stimulus controller #242

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

Ref #210

We had some lingering things coming from the earlier implementation that are no longer necessary.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[ ] I have written a thorough PR description.
[ ] I have kept my commits small and atomic.
[ ] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

elia commented 1 year ago

Merging, the CI failures are related to https://github.com/solidusio/solidus_starter_frontend/pull/332