Closed elia closed 1 year ago
Merging #255 (07723f1) into master (682579e) will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 99.79% 99.79% -0.01%
==========================================
Files 25 25
Lines 481 480 -1
==========================================
- Hits 480 479 -1
Misses 1 1
Impacted Files | Coverage ฮ | |
---|---|---|
...lates/app/views/checkouts/payment/_stripe.html.erb | 100.00% <รธ> (รธ) |
:mega: Weโre building smart automated test selection to slash your CI/CD build times. Learn more
Summary
Extracted from #249
Use the @stripe/stripe-js module with
importmap
, as partially described in the Stripe doc.The
<script>
tag is added to every page to support fraud detection as suggested in the stripe-js repo. We opted for using the script tag instead of relying on the implicit side-effect because the browser will be able to start loading it earlier if it's directly in the HTML.https://github.com/stripe/stripe-js#ensuring-stripejs-is-available-everywhere
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: