solidusio / solidus_stripe

💳 Integrate Solidus with Stripe
https://stripe.com
BSD 3-Clause "New" or "Revised" License
36 stars 61 forks source link

Consider adding placeholder #authorize and #purchase methods to the gateway #267

Closed elia closed 1 year ago

elia commented 1 year ago

Why

In case anyone would read the gateway class implementations we should avoid the surprise of not finding those two methods, that are mentioned in the solidus guides for creating custom gateways.

What

Add the methods along with documentation, consider using either a raise NotImplementedError or a # noop comment as the implementation.

This might be impacted by #266 in case those methods will be implemented because of it.