solidusio / solidus_stripe

πŸ’³ Integrate Solidus with Stripe
https://stripe.com
BSD 3-Clause "New" or "Revised" License
36 stars 61 forks source link

Add caching support to sandbox apps creation #272

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

With a warm cache the sandbox app creation goes from ~130s to ~30s on my Apple M1.

The optimization is used for the dummy-app creation as well.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 year ago

Codecov Report

Merging #272 (30644f7) into master (59f4403) will decrease coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   99.59%   99.56%   -0.03%     
==========================================
  Files          27       26       -1     
  Lines         489      462      -27     
==========================================
- Hits          487      460      -27     
  Misses          2        2              

see 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more