codecov[bot]
commented
1 year ago Codecov Report
Merging #284 (68bebb3) into master (1136a79) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 27 27
Lines 489 489
=======================================
Hits 487 487
Misses 2 2 :mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
elia
Summary
With the new way of testing solidus extensions (through full rails installations) we no longer have much to gain from using solidus_dev_support.
Specifically the only two things we were using it for were:
Rubocop rules
We just had a few dev-support adjustments over the "relaxed" rubocop style, but we also had a handful of local rules.
It seems ok to just import the original list and move from there, all modern tooling will adapt to whatever rules are in the repo (language servers, formatters, etc.).
Releasing
The dev-support releasing toolchain starter at a time in which GitHub releases were not so convenient (if they existed at all). Now it's super easy to store the changelog there directly and be generated with one click.
This of course is ok for extensions as the have a smaller scope and simpler changes (vs. Solidus).
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: