Fix `solidus_gateway` to `solidus_stripe` preference migration (v3)

solidusio / solidus_stripe

💳 Integrate Solidus with Stripe

https://stripe.com

BSD 3-Clause "New" or "Revised" License

36 stars 62 forks source link

Fix `solidus_gateway` to `solidus_stripe` preference migration (v3) #298

Closed benjaminwil closed 1 year ago

benjaminwil commented 1 year ago

Summary

This pull request resolves #273 for v3 of the solidus_stripe extension.

It edits a migration. The migration as written did not not successfully migrate payment method preferences that were created with solidus_gateway to preferences for use with solidus_stripe.

Checklist

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

benjaminwil commented 1 year ago

I'm requesting we release this as patch version v3.2.2 since it's unlikely we'll release another version of v3.

benjaminwil commented 1 year ago

I'm unsure whether CI can pass for this branch?

elia commented 1 year ago

@benjaminwil are you aware of any store running on v3? otherwise I would prefer treating 3.x as unsupported

benjaminwil commented 1 year ago

I'm not, personally! Happy to close this, we just discussed back-porting to v3 briefly in #273. So the work is here if we need it, at least.

I will close this for now.