Add missing `&&` in `SolidusStripe::PaymentIntent.usable?`

solidusio / solidus_stripe

💳 Integrate Solidus with Stripe

https://stripe.com

BSD 3-Clause "New" or "Revised" License

36 stars 62 forks source link

Add missing `&&` in `SolidusStripe::PaymentIntent.usable?` #299

Closed rainerdema closed 1 year ago

rainerdema commented 1 year ago

Summary

This PR fixes a typo within the mentioned method where the condition is currently not fully working due to a missing &&.

Refer to this commit: https://github.com/solidusio/solidus_stripe/commit/33b0ad4e7017693aeaaedbeedaaf2911682d6416

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #299 (2f0a966) into main (aa50d74) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files          30       30              
  Lines         547      546       -1     
==========================================
- Hits          545      544       -1     
  Misses          2        2

Impacted Files	Coverage Δ
app/models/solidus_stripe/payment_intent.rb	`100.00% <ø> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more