solidusio / solidus_stripe

πŸ’³ Integrate Solidus with Stripe
https://stripe.com
BSD 3-Clause "New" or "Revised" License
36 stars 62 forks source link

Add more versions of ruby and more databases to the CI matrix #303

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

elia commented 1 year ago

Had to change all calls to #references and add the foreign key separately, as for each of the this was shown with MySQL:

== 20230428115654 CreateSolidusStripePaymentIntents: migrating ================
-- create_table(:solidus_stripe_payment_intents)
rails aborted!
StandardError: An error has occurred, all later migrations canceled:

Column `order_id` on table `solidus_stripe_payment_intents` does not match column `id` on `spree_orders`, which has type `int(11)`. To resolve this issue, change the type of the `order_id` column on `solidus_stripe_payment_intents` to be :integer. (For example `t.integer :order_id`).
Original message: Mysql2::Error: Cannot add foreign key constraint
/home/circleci/project/dummy-app/db/migrate/20230428115654_create_solidus_stripe_payment_intents.solidus_stripe.rb:4:in `change'

Caused by:
ActiveRecord::MismatchedForeignKey: Column `order_id` on table `solidus_stripe_payment_intents` does not match column `id` on `spree_orders`, which has type `int(11)`. To resolve this issue, change the type of the `order_id` column on `solidus_stripe_payment_intents` to be :integer. (For example `t.integer :order_id`).
Original message: Mysql2::Error: Cannot add foreign key constraint
/home/circleci/project/dummy-app/db/migrate/20230428115654_create_solidus_stripe_payment_intents.solidus_stripe.rb:4:in `change'

Caused by:
Mysql2::Error: Cannot add foreign key constraint
/home/circleci/project/dummy-app/db/migrate/20230428115654_create_solidus_stripe_payment_intents.solidus_stripe.rb:4:in `change'
Tasks: TOP => db:migrate
(See full trace by running task with --trace)
codecov[bot] commented 1 year ago

Codecov Report

Merging #303 (c8528ba) into main (100b9c3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          31       31           
  Lines         563      563           
=======================================
  Hits          561      561           
  Misses          2        2           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more