Re-enable and fix a couple of try_void related specs

solidusio / solidus_stripe

💳 Integrate Solidus with Stripe

https://stripe.com

BSD 3-Clause "New" or "Revised" License

36 stars 62 forks source link

Re-enable and fix a couple of try_void related specs #304

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

The implementation was fine, just had to adjust the expectation and test setup.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #304 (2979d7e) into main (deb292a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          30       30           
  Lines         546      546           
=======================================
  Hits          544      544           
  Misses          2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

elia commented 1 year ago

@waiting-for-dev we initially tried that approach but eventually we rolled it back because there was little to no reuse, as the combinations of flash messages and payment statuses were always different. Maybe there's a case for using I18n here, but that also as its own downsides, and is usually better to use raw values rather than dynamic ones in tests to avoid the equivalent of circular definitions.