solidusio / solidus_stripe

💳 Integrate Solidus with Stripe
https://stripe.com
BSD 3-Clause "New" or "Revised" License
37 stars 61 forks source link

Ensure reloading the confirmation page doesn't break the checkout #317

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

Looks like we missed this pattern in which a payment intent state was advanced while rendering the confirmation page. Adding support for this state ensures we don't get a 500 by simply refreshing the confirmation page.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f6390ee) 99.64% compared to head (04da679) 99.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #317 +/- ## ======================================= Coverage 99.64% 99.64% ======================================= Files 31 31 Lines 563 564 +1 ======================================= + Hits 561 562 +1 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.