Create order finalized subscriber/job for subscription creation

solidusio / solidus_subscriptions

An extension to add subscriptions to your Solidus store.

BSD 3-Clause "New" or "Revised" License

48 stars 53 forks source link

Create order finalized subscriber/job for subscription creation #261

Closed FrancescoAiello01 closed 2 years ago

FrancescoAiello01 commented 2 years ago

Resolves #260

Stop decorating the order#finalize! method to create subscriptions and instead create subscriptions as part of a background job.

FrancescoAiello01 commented 2 years ago

@kennyadsl @elia

kennyadsl commented 2 years ago

@FrancescoAiello01 Thanks, this looks great. I saw that tests on this extension are not running against Solidus master branch. I think it's because of https://github.com/solidusio-contrib/solidus_subscriptions/pull/257/commits/eefdc5feffd35ed229a1a2b347b790f5f2592948, which has not been reverted. It would be great if we could restore it, even with another PR so that we are sure we merge something that works with the last version of Solidus (3.2), which will be released soon.

Thanks!

elia commented 2 years ago

@FrancescoAiello01 Thanks, this looks great. I saw that tests on this extension are not running against Solidus master branch. I think it's because of eefdc5f, which has not been reverted. It would be great if we could restore it, even with another PR so that we are sure we merge something that works with the last version of Solidus (3.2), which will be released soon.

Thanks!

@kennyadsl I'll take care of that 👍