search

solidusio / solidus_support

Common runtime helpers for Solidus extensions.
BSD 3-Clause "New" or "Revised" License
9 stars 23 forks source link

Cast out Poltergeist #10

Closed tvdeyen closed 5 years ago

tvdeyen commented 6 years ago

Instead of having a hard dependency to poltergeist for extensions feature specs, we allow to use selenium-webdriver as well. Error out with warning if non of them are present.

ccarruitero commented 6 years ago

I'm not sure about this.

I like the idea to allow use a different driver than poltergeist, but I don't think the best way should be try to match any specific driver.

Instead we can create a different helper for each driver, and let the user load the driver he prefer.

tvdeyen commented 5 years ago

Instead we can create a different helper for each driver, and let the user load the driver he prefer.

@ccarruitero I like that idea, but currently we hard coded poltergeist and are forcing every extension that uses this feature helper to also install the poltergeist gem. This is mainly a hotfix for that problem. Contributions to separate the adapter code from the rspec feature spec setup code is more then welcome.

kennyadsl commented 5 years ago

Also, which other driver could be added? In the supported drivers list:

So at the moment I think there are no other option.

tvdeyen commented 5 years ago

@kennyadsl give approval?

kennyadsl commented 5 years ago

@tvdeyen sure, it’s already approved!

tvdeyen commented 5 years ago

@kennyadsl ah, dang, we need a second one, right? :)

tvdeyen commented 5 years ago

Closed in favour of #16