search

solidusio / solidus_support

Common runtime helpers for Solidus extensions.
BSD 3-Clause "New" or "Revised" License
9 stars 23 forks source link

Deprecate SolidusSupport.solidus_gem_version #37

Closed kennyadsl closed 4 years ago

kennyadsl commented 4 years ago

It does not make a lot of sense nowadays. We have Spree.solidus_gem_version ( 😆) since Solidus 1.2

spaghetticode commented 4 years ago

This should be green after merging https://github.com/solidusio/solidus_support/pull/36

kennyadsl commented 4 years ago

Would it make sense to introduce a Solidus.gem_version instead?

Spree.gem_version comes from core, I think it will be deprecated in favor of Solidus.gem_version if/when we decide what to do with the namespace.