solidusio / solidus_support

Common runtime helpers for Solidus extensions.
BSD 3-Clause "New" or "Revised" License
9 stars 23 forks source link

Add ffaker dependency to gemspec #4

Closed swcraig closed 7 years ago

swcraig commented 7 years ago

ffaker was removed as a runtime dependency of Solidus.

This gem itself requires ffaker: lib/solidus_support/extensions/rails_helper.rb

Every Solidus extension that does not include ffaker will be broken. Adding the ffaker dependency here will fix all of the reverse dependencies of this gem: https://rubygems.org/gems/solidus_support/reverse_dependencies

PR removing ffaker from Solidus: https://github.com/solidusio/solidus/pull/2163

swcraig commented 7 years ago

I will add ffaker as a development dependency to the relevant gems instead.