search

solidusjs / solidus-site-template

Boilerplate for new Solidus sites, for use with grunt-init
3 stars 1 forks source link

Sass partials should not be compiled #4

Closed pushred closed 11 years ago

pushred commented 11 years ago

The glob for the sass task is currently too open, it should exclude any files beginning with _ as these are by spec not to be compiled individually. Attempting to compile them often fails because they are intended only to be loaded with @import in places where variables, mixins, etc. are expected to be accessible.

I tried modifying my Gruntfile per the following, but it didn't seem to work, maybe not the right way to spec a prefix in the glob expression?

Paths matching patterns that begin with ! will be excluded from the returned array.

Failed Glob

'assets/compiled/styles_tmp.css': ['!assets/styles/**/_*.scss','assets/styles/**/*.scss','assets/styles/**/*.css']
Fauntleroy commented 11 years ago

I don't think this matters anymore, since we're only compiling index.scss and forcing users to import to it.