search

solidusjs / solidus

A simple server that generates pages from JSON and Templates
MIT License
28 stars 7 forks source link

Set X-Powered-By header. #112

Closed joanniclaborde closed 10 years ago

joanniclaborde commented 10 years ago

Sets the X-Powered-By header to Solidus/{version}, for example Solidus/0.1.7.

jameslovejoy commented 10 years ago

I like this feature :star2:

However, if solidus returns a 404, the header still shows Express:

$ curl -i http://lvh.me:8080/foo
HTTP/1.1 404 Not Found
X-Powered-By: Express
Vary: Accept-Encoding
Content-Type: text/html; charset=utf-8
Content-Length: 13
Date: Thu, 26 Jun 2014 18:50:14 GMT
Connection: keep-alive

404 Not Found
jameslovejoy commented 10 years ago

Maybe this should be a separate feature request, but I would find it helpful to see the version number in the console when developing locally. Something like:

[SOLIDUS] Server 0.1.7 running on port 8080
joanniclaborde commented 10 years ago

Nice catch! I fixed both issues.

jameslovejoy commented 10 years ago

:+1: :+1: