search

solidusjs / solidus

A simple server that generates pages from JSON and Templates
MIT License
28 stars 7 forks source link

Allow site paths to have spaces #65

Closed Fauntleroy closed 11 years ago

Fauntleroy commented 11 years ago

By switching glob out for fileset file paths with spaces can be used. In order to test this, the site1 fixture has been changed to site 1.

pushred commented 11 years ago

While technically possible for a development server in certain browsers this seems like a bad thing to promote. Spaces could present issues further down and of course ultimately in the UX. Links would need to be encoded to work properly. This isn't Storyteller where we didn't have a real filesystem and could get away with friendly space-filled partial names. Does everything work as expected in Handlebars? How about in Windows & Linux?

Fauntleroy commented 11 years ago

I'm not "promoting" it, I'm just making it work. We had a user start a site in something like: ~/Username/GitHub Repositories/sparkart.com/. The file matching module I used before (fileset) didn't match properly, so I moved over to glob, which does. This doesn't really deal with spaces in route names, or anything like that, but deeper down. Spaces in route names aren't tests, and last time I checked, didn't actually work.

pushred commented 11 years ago

Oh never mind, I was misinterpreting the scope. Definitely a legitimate use case where spaces may exist outside of the site. The solution seems straightforward enough and effective if tests pass and I see glob has some for Windows. :+1:

Fauntleroy commented 11 years ago

Yes, glob is also more popular, and written by Isaac, so I'm good with it :). Merging.