redirects must be set to permanent explicitly

solidusjs / solidus

A simple server that generates pages from JSON and Templates

MIT License

28 stars 7 forks source link

redirects must be set to permanent explicitly #67

Closed Fauntleroy closed 10 years ago

Fauntleroy commented 11 years ago

Changes the behavior of redirects from:

Automatically being permanent if no start or end is specified

to:

Only being permanent if the permanent flag is set. Permanent redirects can also have a start and an end, but the browser will cache them aggressively, so it's not recommended to depend on it.

Fauntleroy commented 10 years ago

@pushred review pls

pushred commented 10 years ago

This change is definitely a good idea. I think this qualifies as a major version update due to the addition of the permanent requirement. Any extant redirects lacking start / end would no longer be considered permanent so that's a breaking change in my book. Good to do it now though based on confusion we've seen in use thus far.

Fauntleroy commented 10 years ago

@pushred According to semver we can do some pretty substantial changes while we're in major version 0:

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

pushred commented 10 years ago

I see, well at least we know who this change will effect.

pushred commented 10 years ago

Can you tag & release this and other recent changes? Not doing much good in master...

Fauntleroy commented 10 years ago

Tagged and released.