solismc / Projects

Repository of projects I've worked on
1 stars 0 forks source link

Week 01 Weekend - Portfolio - #4

Closed mdewey closed 6 years ago

mdewey commented 6 years ago

A Portfolio

For your first weekend project, we're going to be starting work on a portfolio website that you can improve over the rest of your career.

Mockup

You can find image assets you'll need here:

https://github.com/tiy-tpa-fee/assignments/tree/master/portfolio/assets

The font used is Roboto.

Objectives

Requirements

Explorer Mode

Adventure Mode

solismc commented 6 years ago

https://github.com/solismc/portfolio

Mark, here is my weekend project. I must say, I am quite proud of my work. I realize your say overrides my subjective, and possibly biased, opinion, lol.

Top section has some room for improvement. Separating Jason's image and text bubble. Struggled a bit to figure out how to do that.

Pleased with the Footer box. My OCD kicked-in and notice it is not aligned 100%. I inspected the elements and tried to solve the problem. I think I know where the issue is. There is a user agent stylesheet that has a left side padding of 40px that I cannot figure out how to override. Once that is overridden, it should align quite nicely.

mdewey commented 6 years ago

Great job overall! My only real feedback is to make your commit messages a bit more meaningful that 'Sunday 5:30pm'. Make the messages more descriptive of what you did. this will help you (and your team) know what exactly you did

solismc commented 6 years ago

Hi Mark,

Thanks for the feedback. I will work on that.

Make it a great day!

Manuel

On Mon, Jul 30, 2018 at 9:42 AM Mark Dewey notifications@github.com wrote:

Great job overall! My only real feedback is to make your commit messages a bit more meaningful that 'Sunday 5:30pm'. Make the messages more descriptive of what you did. this will help you (and your team) know what exactly you did

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/solismc/Assignments/issues/4#issuecomment-408867368, or mute the thread https://github.com/notifications/unsubscribe-auth/AnTChjLpg1f3knacYGkEm_3cWp4xdsJHks5uLw0ogaJpZM4ViNZa .

mdewey commented 6 years ago

Awesome Work!