search

solitontech / SLL-Toolkit

Collection of LabVIEW Reusables.
MIT License
10 stars 5 forks source link

Improve SLL LabVIEW Code Compare Tool for Git #12

Open SatheeshvarmaSJ opened 5 months ago

SatheeshvarmaSJ commented 5 months ago

Based on review comments from #11, best practices improvements are mentioned below.

  1. The main cluster has all elements flat. It would be good to organize them under subclusters for better devX and maintainability.
  2. Would it better to make all UI visibility, enable/disable, UI updates to be in 3 separate cases and avoid doing this inside other cases?
  3. Currently all the business logic is present in a single VI as a GUI. It would be helpful to split the core functionalities into APIs, which can then be called in a GUI. In this way, if someone wants to make changes or wants to implement a different user case, they can do so.

Other pending items,

  1. Improve the tool for better meaningful errors instead of default errors.
  2. Could reduce the dependencies usage to make the tool and package light weight.
  3. Test tool with various scenarios and remove the "beta" tag.