solivas612 / ColmarAcademy

0 stars 0 forks source link

Colmar Academy (BWS) #1

Open asadmehdi785 opened 6 years ago

asadmehdi785 commented 6 years ago

Rubric Score

Criteria 1: HTML is structured to reflect the grouping, flow, and positioning of content

Criteria 2: Layout for desktop and mobile

Criteria 3: Responsiveness using media queries and responsive units

Criteria 4: Accessible color palette, typographic decisions, and CSS transitions to make a visually accessible and interesting web page.

Overall Score: 16/16

Outstanding work with this project! You did an excellent job in all aspects of the project, from keeping your code and project contents organized to implementing the specification. Very well done! I thought the website looked very clean and you definitely put a lot of time and effort making sure the styling for everything was just right, while also keeping it very responsiveness.

I noticed that you had a lot of div tags in your HTML, some of which could be replaced with more semantic tags from HTML5. Some of these include header, nav, and footer. Using these types of tags can help make your page more accessible and reduce the reliance on div tags.

Additionally, you did a good job placing the video on the webpage as asked in the specification. However, perhaps you might want to try making it autoplay upon loading the page, with the video controls removed. I think that would add a nice touch to your website. Of course, this isn't explicitly specified in the spec, but seeing as how you did a great job following the spec otherwise (while adding your own customizations), it might be something extra that you could try out. It's completely up to you though!

Excellent work overall! I hope you enjoyed the course!

solivas612 commented 6 years ago

Thanks! I tried applying autoplay but ran into issues of it not being displayed at all. I wasn't sure why.

Thanks again! Learned tons!