search

solnic / virtus

[DISCONTINUED ] Attributes on Steroids for Plain Old Ruby Objects
MIT License
3.77k stars 229 forks source link

[WIP] Attribute refactor #144

Closed solnic closed 11 years ago

solnic commented 11 years ago

This is a pretty big refactor that splits Attribute responsibilities across reader and writer objects. This is still a WIP. I pushed early so that I can track travis status. I'll let you know when it's ready for a review.

EDIT: @dkubb @mbj this is ready for a review :smile: I still need to add mutation cov but I think I'm gonna hold off and wait until we have "types" extracted too

solnic commented 11 years ago

@dkubb @mbj any comments? I want to merge it in :smile:

dkubb commented 11 years ago

@solnic I can review it tonight if you want.

solnic commented 11 years ago

@dkubb yes please. after merging this in I'll wait for types lib and when it's done I'll integrate it with virtus and push 1.0.0.rc1 or 1.0.0.beta

dkubb commented 11 years ago

@solnic I've done a first pass over the code. I didn't see anything major, most of my comments were about naming I think.