search

solnic / virtus

[DISCONTINUED ] Attributes on Steroids for Plain Old Ruby Objects
MIT License
3.77k stars 229 forks source link

Remove backports gem #168

Closed jgaskins closed 11 years ago

jgaskins commented 11 years ago

Since 1.8 support was removed in 845b36ec36bd82c2f49063c9d3c6fd52a0b54864, it doesn't appear that backports is necessary anymore. I ran rake under 1.9.2 and it gives no failures, so that's a good sign. Is there anything else I need to check here?

solnic commented 11 years ago

@jgaskins https://github.com/solnic/virtus/blob/master/lib/virtus.rb#L2 :)

jgaskins commented 11 years ago

Oh, right. :-) Well, I understand how this passed on my machine (I hadn't removed the gem), but how does it pass on Travis? Doesn't it get a fresh bundle every build?

jgaskins commented 11 years ago

Ah, it's still a dependency of dependencies.

➜  virtus git:(remove-backports-gem) gem uninstall backports

You have requested to uninstall the gem:
    backports-3.3.0
abstract_type-0.0.5 depends on [backports (>= 3.0.3, ~> 3.0)]
adamantium-0.0.7 depends on [backports (>= 3.0.3, ~> 3.0)]
coercible-0.2.0 depends on [backports (>= 3.1.0, ~> 3.0)]
equalizer-0.0.5 depends on [backports (>= 3.0.3, ~> 3.0)]
mutant-0.2.20 depends on [backports (>= 3.0.3, ~> 3.0)]
yardstick-0.9.5 depends on [backports (>= 3.0.3, ~> 3.0)]
If you remove this gems, one or more dependencies will not be met.
Continue with Uninstall? [Yn]
jgaskins commented 11 years ago

Alrighty, removed the require. Until everyone else removes their dependency on it it'll still be there, but at least this will remove the dependency from Virtus itself. :-)

solnic commented 11 years ago

Thanks Jamie! We are supposed to remove ruby 1.8 support from other projects in June when ruby core team drops it too. Then backports dep will be gone for good :)

jgaskins commented 11 years ago

:+1: for GCing dependencies!

dzaporozhets commented 10 years ago

@solnic Hi! Great change! Still one wish. virtus depends on coercible which depends on backports. So installing virtus still grub this gem as dependecy. In master coercible does not rely on backports any more. Can we release new version of coercible and bump virtus?

solnic commented 10 years ago

@randx yes and in fact just yesterday I noticed the same thing and realized I need to push a new release of coercible along with virtus 1.0.1

dzaporozhets commented 10 years ago

@solnic awesome! Thank you