search

solnic / virtus

[DISCONTINUED ] Attributes on Steroids for Plain Old Ruby Objects
MIT License
3.77k stars 229 forks source link

Bundler can resolve a compatible set of versions of development dependencies #180

Closed marten closed 11 years ago

marten commented 11 years ago

I tried creating a patch to Virtus, but got stuck on the very first step: installing all depedencies. Running bundle install fails because your devtools library seems to depend on a too-new version of ice_nine.

Bundler could not find compatible versions for gem "ice_nine":
  In Gemfile:
    mutant (~> 0.2.20) ruby depends on
      ice_nine (~> 0.7.0) ruby

    devtools (>= 0) ruby depends on
      ice_nine (0.8.0)

It might just be that the Gemfile wants a specific SHA1. Normally the Gemfile.lock does this for you, but for gems this is usually not checked in, as is the case for virtus.

solnic commented 11 years ago

@marten sorry about that, updating dev deps is not a smooth experience at the moment. we'll be improving that soon in devtools. I just updated everything, so please pull from master and bundle install will work.

solnic commented 11 years ago

...pssst @mbj - that's why I didn't like devtools having dependencies :P /cc @dkubb @snusnu

dkubb commented 11 years ago

@solnic so you're suggesting we remove https://github.com/rom-rb/devtools/blob/master/devtools.gemspec#L17 ?

I think I'd be ok with removing the dep on ice_nine. devtools is simple enough that it's not really necessary.

mbj commented 11 years ago

@solnic Why dont just fix the deps?

solnic commented 11 years ago

@mbj because we wouldn't have that discussion if there were no deps and maybe the patch for virtus would've been already done

On Sun, Jul 14, 2013 at 7:02 PM, Markus Schirp notifications@github.com wrote:

@solnic Why dont just fix the deps?

Reply to this email directly or view it on GitHub: https://github.com/solnic/virtus/issues/180#issuecomment-20939563