Open solnic opened 10 years ago
It may be better to use attribute
as argument for extend?
method, because extension may want to access not only options, but i.e. name, to decide to be applied or not.
That's a great suggestion
On Thu, Oct 3, 2013 at 3:55 PM, mirasrael notifications@github.com wrote:
It may be better to use
attribute
as argument forextend?
method, because extension may want to access not only options, but i.e. name, to decide to be applied or not.Reply to this email directly or view it on GitHub: https://github.com/solnic/virtus/issues/208#issuecomment-25622146
Are you working on this feature or I can suggest it as pull request?
No I'm not planning to work on it anytime soon. Would love to see a PR :)
On Thu, Oct 3, 2013 at 4:04 PM, mirasrael notifications@github.com wrote:
Are you working on this future or I can suggest it as pull request?
Reply to this email directly or view it on GitHub: https://github.com/solnic/virtus/issues/208#issuecomment-25622883
I opened pull request #209
@mirasrael thanks! that was fast :) I left some comments
As discussed in #207
IMPORTANT: this won't block 1.0.0 though, can be added in 1.x as it's just a new feature. Details have not been defined yet.