search

solnic / virtus

[DISCONTINUED ] Attributes on Steroids for Plain Old Ruby Objects
MIT License
3.77k stars 228 forks source link

Did you forget to push tags to GH repository? #213

Closed zekefast closed 10 years ago

zekefast commented 10 years ago

Please, push tags for versions on rubygems.org to GitHub, at least for latest 1.0.0.rc2.

Thank you in advance!

solnic commented 10 years ago

Damn :/ Yeah I forgot about tags

On Fri, Oct 11, 2013 at 3:49 PM, Zeke Fast notifications@github.com wrote:

Please, push tags for versions on rubygems.org to GitHub, at least for latest 1.0.0.rc2.

Thank you in advance!

Reply to this email directly or view it on GitHub: https://github.com/solnic/virtus/issues/213

zekefast commented 10 years ago

You can just use --tags option with git push when pushing on GH. ;)

solnic commented 10 years ago

Do you know what's the easiest way to find sha1 for releases?

zekefast commented 10 years ago

Do you mean having code find sha1 for it? I think it's impossible exactly determine the commit by code, because even same code committed on different time has different hashes. If you have no tags for previous releases and I'm the only who notice that. I'd suggest don't bothering with tagging and just pay attention to this in future or use git bisect to find commit sure and tag it sure if you have sing of release (like version bump in files or release notes).

solnic commented 10 years ago

I always tag releases. I forgot this time because it was a pre-release and I was in rush :(

On Sun, Oct 13, 2013 at 4:43 PM, Zeke Fast notifications@github.com wrote:

Do you mean having code find sha1 for it? I think it's impossible exactly determine the commit by code, because even same code committed on different time has different hashes. If you have no tags for previous releases and I'm the only who notice that. I'd suggest don't bothering with tagging and just pay attention to this in future or use git bisect to find commit sure and tag it sure if you have sing of release (like version bump in files or release notes).

Reply to this email directly or view it on GitHub: https://github.com/solnic/virtus/issues/213#issuecomment-26219180

dkubb commented 10 years ago

I try to use gem release --tag, but I forget the switch sometimes. I wish it was the default or there was a way to configure it to be the default.

GBH commented 10 years ago

@dkubb alias gem-release="gem release --tag"

mbj commented 10 years ago

Lets move this to devtools ;) devtools release ?

dkubb commented 10 years ago

@GBH oh right! good call.

@mbj Yeah, that wouldn't be so bad.. I guess using an alias will deal with a lot of the pain though.

solnic commented 10 years ago

I don't use gem release - what does it do exactly?

GBH commented 10 years ago

@solnic It's this thing: https://github.com/svenfuchs/gem-release I ditched jeweler for this and I really like it.

dkubb commented 10 years ago

Yeah, it's a nice single purpose library. It adds the "release" command to gem. With the --tag switch it will add a version tag at the same time it pushes to rubygems.

solnic commented 10 years ago

I just recalled I used to use it and then I stopped, not sure why.

elskwid commented 10 years ago

Seems like just tagging the shas where the version was bumped would do it. https://github.com/solnic/virtus/commits/master/lib/virtus/version.rb

elskwid commented 10 years ago

@zekefast, I'm closing this issue now. If you need access to these tags for any reason, please let me know, otherwise, I'm going to leave it be since 1.0 has been released.

zekefast commented 10 years ago

@elskwid, Since 1.0 was released this is Okay. Thanks!