solnic / virtus

[DISCONTINUED ] Attributes on Steroids for Plain Old Ruby Objects
MIT License
3.77k stars 229 forks source link

Upgrade Ruby Version to 2.0.0 #237

Closed baweaver closed 10 years ago

baweaver commented 10 years ago

Are there any reasons why the Ruby version is locked at 1.9.3? I would expect Gem compatibility.

The 2.0.0 upgrade does do quite a bit in the ways of garbage collection enhancements and general speed boosts all around. The GC patches alone would be worth it, especially on expensive creations. I would venture a guess that if ruby-prof were run on this GC would be heavy. I'll get statistics to back this.

solnic commented 10 years ago

@baweaver what do you mean it's locked? virtus works fine on ruby 2.0.0

baweaver commented 10 years ago

Granted, but the ruby version it has set is 1.9.3 for some reason. RVM catches it and alerts it.

solnic commented 10 years ago

1.9.3 is the primary ruby I use when I work on virtus. This has nothing to do with the supported platforms. Please see travis matrix for the ruby vms virtus supports.

Sorry for the confusion. I'm gonna close this now.