solnic / virtus

[DISCONTINUED ] Attributes on Steroids for Plain Old Ruby Objects
MIT License
3.77k stars 229 forks source link

Allow mixing in multiple Virtus.modules #276

Closed trptcolin closed 10 years ago

trptcolin commented 10 years ago

Known caveat: if one module wants constructors/coercions/mass-assignment but the other one doesn't, the one that does want those features will win since it mixes in the module (this problem already exists though, so this patch doesn't make things any worse).

fixes #260 fixes #274

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.0%) when pulling 3869c642e4d868c1da54d4fee2441471faf19ece on trptcolin:multiple_modules into b278c928aabad8f4d8ef3866cbe985fbe82d5d04 on solnic:master.

solnic commented 10 years ago

Thank you! <3

I guess we could warn if somebody is trying to mixin modules with different configurations.

HonestAbe commented 10 years ago

:+1: