Virtus::Attribute::Collection.value_coerced? override.

solnic / virtus

[DISCONTINUED ] Attributes on Steroids for Plain Old Ruby Objects

MIT License

3.77k stars 229 forks source link

Virtus::Attribute::Collection.value_coerced? override. #343

Closed dslh closed 8 years ago

dslh commented 9 years ago

Added override of Virtus::Attribute.value_coerced? to Virtus::Attribute::Collection, which checks collection members against the expected member type. Prevents e.g. Virtus::Attribute.build(Array[Integer]).value_coerced? %w{1 2 3} from returning true.

dblock commented 9 years ago

:+1: we (Grape) would love this to be merged

dblock commented 8 years ago

@dslh Will you finish this PR, I am happy to reopen a new one after addressing the issues by the maintainers.

dslh commented 8 years ago

Commas all sorted, really I should know better :)

Let me know if I've missed anything else.

u2 commented 8 years ago

@booch