search

solo-io / envoy-gloo

Apache License 2.0
25 stars 14 forks source link

add creds for build cache #313

Closed ben-taussig-solo closed 8 months ago

ben-taussig-solo commented 8 months ago

Open source companion to https://github.com/solo-io/envoy-gloo-ee/pull/746 One change here is identical to those from that PR:

The method we were hooking into for setting the build cache creds was deprecated in this PR and removed entirely in this PR.

This PR takes the creds management added to some of the azure actions in the latter linked PR and adapts it for use in our own do_ci.sh.

In addition, this PR exports BAZEL_BUILD_EXTRA_OPTIONS, explicitly setting the --remote-cache bazel flag to the value of BAZEL_REMOTE_CACHE, which is currently set by ci/cloudbuild.yaml

As you can see in the first PR linked above, this change is also necessary to ensure that envoy-gloo CI targets the proper remote cache URL

    echo "Setting BAZEL_REMOTE_CACHE is deprecated, please use BAZEL_BUILD_EXTRA_OPTIONS " \
         "or use a user.bazelrc config " >&2
ben-taussig-solo commented 8 months ago

/skip-changelog CI creds only change

jbohanon commented 8 months ago

This didn't actually have any effect because the BAZEL_BUILD_EXTRA_OPTIONS wasn't exported to be available to upstream's CI. I have fixed that in https://github.com/solo-io/envoy-gloo/pull/312