search

solo-io / gloo-portal-issues

Public tracker for issues related to Gloo Portal
https://docs.solo.io/gloo-portal/latest/
1 stars 3 forks source link

Dashboard created by gloo-portal.gloo-portal upstream is rejected by grafana #133

Closed jameshbarton closed 2 years ago

jameshbarton commented 2 years ago

Describe the bug The GEE observability deployment logs consistently show the dashboard created from the gloo-portal.gloo-portal upstream is rejected by grafana.

There are many error records in the logs like this:

{"level":"error","ts":"2021-11-18T22:56:48.412Z","logger":"observability.v1.event_loop.observability","caller":"syncer/setup_syncer.go:143","msg":"error: event_loop: All attempts fail:\n#1: Encountered errors while communicating with Grafana while creating new content: 1 error occurred:\n\t* failed to save dashboard to grafana for upstream: gloo-portal.gloo-portal: 400 {\"message\":\"uid contains illegal characters\"}\n\n\n#2: Encountered errors while communicating with Grafana while creating new content: 1 error occurred:\n\t* failed to save dashboard to grafana for upstream: gloo-portal.gloo-portal: 400 {\"message\":\"uid contains illegal characters\"}\n\n\n#3: Encountered errors while communicating with Grafana while creating new content: 1 error occurred:\n\t* failed to save dashboard to grafana for upstream: gloo-portal.gloo-portal: 400 {\"message\":\"uid contains illegal characters\"}\n\n\n#4: Encountered errors while communicating with Grafana while creating new content: 1 error occurred:\n\t* failed to save dashboard to grafana for upstream: gloo-portal.gloo-portal: 400 {\"message\":\"uid contains illegal characters\"}\n\n\n#5: Encountered errors while communicating with Grafana while creating new content: 1 error occurred:\n\t* failed to save dashboard to grafana for upstream: gloo-portal.gloo-portal: 400 {\"message\":\"uid contains illegal characters\"}\n\n\n#6: Encountered errors while communicating with Grafana while creating new content: 1 error occurred:\n\t* failed to save dashboard to grafana for upstream: gloo-portal.gloo-portal: 400 {\"message\":\"uid contains illegal characters\"}\n\n\n#7: Encountered errors while communicating with Grafana while creating new content: 1 error occurred:\n\t* failed to save dashboard to grafana for upstream: gloo-portal.gloo-portal: 400 {\"message\":\"uid contains illegal characters\"}\n\n","version":"1.9.1","stacktrace":"github.com/solo-io/solo-projects/projects/observability/pkg/syncer.RunObservability.func1\n\t/workspace/solo-projects/projects/observability/pkg/syncer/setup_syncer.go:143"}

@marcogschmidt says this:

I have never seen this error before, but it’s also been a while since I last paid attention to that deployment, so I’m not sure if this is a new error or if we just never caught it before. Looking at the code it seems that we generate UID the error is complaining about from the upstream name. I wonder whether it is because of the .. If that is the cause we should sanitize the UID string we generate accordingly in edge.

To Reproduce This appears to occur naturally with Edge Enterprise 1.9.1 and Portal 1.1.2

Expected behavior There are no errors with generated dashboard for Portal upstreams.

Additional context

bewebi commented 2 years ago

This bug is resolved in Enterprise 1.11.0-beta11 by solo-io/solo-projects#3185