search

solo-io / gloo-portal-issues

Public tracker for issues related to Gloo Portal
https://docs.solo.io/gloo-portal/latest/
1 stars 3 forks source link

Portal becomes unavailable when invalid APIProduct configuration is applied #153

Closed kcbabo closed 2 years ago

kcbabo commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Update an API Product with incorrect configuration. For instance, set an incorrect operation id (e.g. headers-incorrect) for the referenced API Doc.

After that update, you will observer:

  1. The APIProduct status transitions to invalid.
  2. The Environment status transitions to invalid.
  3. The portal CRD status shows Processing.
  4. The portal is now not accessible to end users.

Expected behavior Ideal case: implement a validation webhook that validates configuration on apply and rejects invalid configuration. This is likely wrapped up in a much larger epic to provide syntactic and semantic validation for Portal CRs. Short term: degrade the portal gracefully if bad API product configuration is applied. The portal should still be available, but may show errors or omit APIs if they are invalid.

kcbabo commented 2 years ago

https://solo-io.zendesk.com/agent/tickets/482

jameshbarton commented 2 years ago

Similar to #152

spunuru commented 2 years ago

This issue can also be reproduced by adding a non-existing usagePlan (usagePlan that is defined in Environment CRD) to APIProduct CRD.

bewebi commented 2 years ago

This bug has been resolved and is released in v1.2.0-beta7 Environments and Portals will now omit invalid API Products without failing