solo-io / gloo

The Cloud-Native API Gateway and AI Gateway
https://docs.solo.io/
Apache License 2.0
4.1k stars 446 forks source link

Makes the TCPRoute controller optional #10305

Closed danehans closed 6 hours ago

danehans commented 3 days ago

Description

Fixes #10304

API changes

None

Code changes

CI changes

Updates the scheme used by tests.

Docs changes

N/A

Context

Interesting decisions

Testing steps

Checklist:

solo-changelog-bot[bot] commented 3 days ago

Issues linked to changelog: https://github.com/solo-io/gloo/issues/10304

danehans commented 7 hours ago

The failing CI test is passing when run locally:

$ go test -v ./projects/gateway2/setup
...
--- PASS: TestScenarios (32.05s)
    --- PASS: TestScenarios/failover-default-diffns (1.10s)
    --- PASS: TestScenarios/failover-default (1.15s)
    --- PASS: TestScenarios/failover (1.13s)
    --- PASS: TestScenarios/happypath (1.13s)
    --- PASS: TestScenarios/listeneropts (1.06s)
PASS
ok      github.com/solo-io/gloo/projects/gateway2/setup 32.117s

Rebasing to try resolving the CI failure.