Closed bdecoste closed 4 months ago
I'm wary of doing anything that masks an error like this. In general, if there are invalid settings, the behavior of these pods is undefined, and crashing seems preferable to only logging an error (as with all config errors, if the gateway proxy was previously configured, it will retain it's last known good configuration until Gloo is back online).
Even though you could say it's safe in the case of bad rate limiting config to fall back on not-rate-limited behavior, I think we'll eventually regret masking such an error, and generally will make mistakes about what settings are allowed to be invalid without degrading functionality.
All that said, this should be something that can be prevented with an admission control webhook.
An offline solution to validate a bundle of config would resolve this any many other issues related to invalid config.
This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.
This issue has been closed due to no activity in the last 12 months.
Note
unit: minutes
below vsunit: MINUTE
This is with validation enabled.