search

solo-io / gloo

The Cloud-Native API Gateway and AI Gateway
https://docs.solo.io/
Apache License 2.0
4.1k stars 446 forks source link

proper use of helm hooks #2679

Closed kdorosh closed 5 months ago

kdorosh commented 4 years ago

in the past, we used helm hooks to avoid race conditions when deploying the chart.

we have since removed some (but not all of) these hooks as races have been removed.

we have never added helm.sh/resource-policy: keep to any of our hooks.

The resources that a hook creates are currently not tracked or managed as part of the release. Once Helm verifies that the hook has reached its ready state, it will leave the hook resource alone. Garbage collection of hook resources when the corresponding release is deleted may be added to Helm 3 in the future.

https://helm.sh/docs/topics/charts_hooks/

let's review our use of hooks, adding this annotation when needed, so that we don't get burned by a new feature once added to helm 3

kdorosh commented 4 years ago

looks like we need to add this annotation to our validating admission webhook. The rest of the use cases look fine to me.

github-actions[bot] commented 11 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.

github-actions[bot] commented 5 months ago

This issue has been closed due to no activity in the last 12 months.