search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.06k stars 432 forks source link

Improve error messages #5011

Open antonioberben opened 3 years ago

antonioberben commented 3 years ago

Is your feature request related to a problem? Please describe. When I run glooctl check I retrieve following error:

* Listener Error: SSLConfigError. Reason: no certificate information found

Describe the solution you'd like Me, as a user, I cannot track down which certificate is triggering the error message so that I can easily run a fix or check what is the root cause.

It would be very interesting to add more details to that error message pointing to which certificate should be expected. The function looks like it already brings the details from the expected certificate. The error message could show following details:

As well, the error message is used in two places with different route cause: https://github.com/solo-io/gloo/blob/7bbe420a2c01116599b3de4d272a9b14d9ef81f3/projects/gloo/pkg/utils/ssl.go#L258 https://github.com/solo-io/gloo/blob/7bbe420a2c01116599b3de4d272a9b14d9ef81f3/projects/gloo/pkg/utils/ssl.go#L264

It would be convenient to distinguish them in order to better debugging.

Thank you

github-actions[bot] commented 2 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.