search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.04k stars 432 forks source link

Helm chart install: support disabling linkerd sidecar injection (similar to disabling istio sidecar injection) #5139

Open gregbacchus opened 2 years ago

gregbacchus commented 2 years ago

Is your feature request related to a problem? Please describe. Yes, we have linkerd injection enabled in the namespace where Gloo is installed and need to be able to run Gloo without the linkerd sidecars.

Describe the solution you'd like In the templates, where ever istio sidecar injection is disabled (with istioIntegration.disableAutoinjection) also add .Values.global.linkerdIntegration.disableAutoinjection which adds the annotation

"linkerd.io/inject": disabled

Describe alternatives you've considered Currently I have to keep a fork of the chart with manual modifications.

Recently there have been additions to many places to be able to add "extra annotations" however this hasn't been done across the board (e.g. jobs), so can't be used.

Additional context Might also be useful to have a global extra annotations option... or maybe global.workloads.extraAnnotations

github-actions[bot] commented 1 month ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.