solo-io / gloo

The Cloud-Native API Gateway and AI Gateway
https://docs.solo.io/
Apache License 2.0
4.1k stars 446 forks source link

readGatewaysFromAllNamespaces not honored in list validation #5357

Open kdorosh opened 3 years ago

kdorosh commented 3 years ago

Describe the bug see https://github.com/solo-io/gloo/blob/b25062e48273db70f7ddbcb018db3f3f07377b6e/projects/gateway/pkg/services/k8sadmisssion/validating_admission_webhook.go#L301

this validation happens before we try to validate a list of resources, and should be moved into the validator in validator.go

To Reproduce Steps to reproduce the behavior:

  1. kube apply '...'
  2. curl '....'
  3. See error

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here, e.g.

github-actions[bot] commented 5 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.