solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.07k stars 435 forks source link

glooctl uninstall --all for Edge Enterprise leaves orphaned CRDs #5385

Open jameshbarton opened 2 years ago

jameshbarton commented 2 years ago

Describe the bug glooctl uninstall --all for Edge Enterprise leaves orphaned CRDs behind

To Reproduce

  1. glooctl install gateway enterprise --license-key $GLOO_KEY
  2. 
    % glooctl uninstall --all
    Uninstalling Gloo Edge...
    Removing Gloo system components from namespace gloo-system...
    Removing Gloo CRDs...
    Removing namespace gloo-system... Done.

Gloo was successfully uninstalled.

3. Note that Fed-related CRDs are not cleaned up as expected.

% kubectl get crds | grep solo federatedratelimitconfigs.fed.ratelimit.solo.io 2021-09-27T17:34:25Z kubernetesclusters.multicluster.solo.io 2021-09-27T17:34:26Z multiclusterrolebindings.multicluster.solo.io 2021-09-27T17:34:26Z multiclusterroles.multicluster.solo.io 2021-09-27T17:34:26Z


**Expected behavior**
All Edge Enterprise CRDs should be removed with `--all` option.

**Additional context**
* See also related customer [discussion](https://solo-io.slack.com/archives/C02E288PQH1/p1632511765016300). 
* Edge version:

% glooctl version Client: {"version":"1.8.17"} Server: {"type":"Gateway","enterprise":true,"kubernetes":{"containers":[{"Tag":"1.8.17","Name":"discovery","Registry":"quay.io/solo-io"},{"Tag":"1.8.13","Name":"extauth-ee","Registry":"quay.io/solo-io"},{"Tag":"1.8.17","Name":"gateway","Registry":"quay.io/solo-io"},{"Tag":"1.8.13","Name":"gloo-ee-envoy-wrapper","Registry":"quay.io/solo-io"},{"Tag":"1.8.13","Name":"gloo-ee","Registry":"quay.io/solo-io"},{"Tag":"1.8.13","Name":"observability-ee","Registry":"quay.io/solo-io"},{"Tag":"1.8.13","Name":"rate-limit-ee","Registry":"quay.io/solo-io"},{"Tag":"5","Name":"redis","Registry":"docker.io"}],"namespace":"gloo-system"}}


- Kubernetes version v1.20.9-gke.1001
github-actions[bot] commented 3 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.