Reduce complexity in gateway's translator_syncer.go - Githubissues

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy

https://docs.solo.io/

Apache License 2.0

4.07k stars 435 forks source link

Reduce complexity in gateway's translator_syncer.go #5812

Open gunnar-solo opened 2 years ago

gunnar-solo commented 2 years ago

Version

Gatway's translator_syncer has been juggling some tech debt for a bit, which could afford to be removed. In particular:

    // Tech Debt:  we've identified that it's not useful to have both two parallel data structures
    //      proxyToLastStatus       map[string]reportsAndStatus
    //      currentGeneratedProxies []*core.ResourceRef
    // floating around.  Historically, they were there to envorce an alphabetical processing of
    //  `proxyToLastStatus`

an optimal solution would look like...

eliminating the currentGeneratedProxies data structure
fully clearing proxyToLastStatus on every call of setCurrentProxies
renaming of the resulting data structure to be more relevant

github-actions[bot] commented 3 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.