search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.08k stars 438 forks source link

FailoverScheme can't be deleted if the status is FAILED #5840

Open jmunozro opened 2 years ago

jmunozro commented 2 years ago

Gloo Edge Version

1.9.x

Kubernetes Version

1.21.x

Describe the bug

A FailOverScheme that is not accepted can't be deleted, because the finalizer prevents it.

Steps to reproduce the bug

apiVersion: fed.solo.io/v1
kind: FailoverScheme
metadata:
  finalizers:
    - fed.solo.io/finalizer
  name: sample-backend-use1
  namespace: default
spec:
  failoverGroups:
    - priorityGroup:
        - cluster: euc1
          upstreams:
            - name: sample-backend-service
              namespace: default
  primary:
    clusterName: use1
    name: sample-backend-service
    namespace: default
status:
  message: 'failed to get client for cluster use1: Failed to get manager for cluster
    use1'
  observedGeneration: 1
  processingTime: "2022-01-28T11:18:25.958294021Z"
  state: FAILED

This can't be removed unless you set the finalizer as null

Expected Behavior

Finalizer should not prevent the deletion of erroneous objects

Additional Context

No response

github-actions[bot] commented 4 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.