search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.07k stars 437 forks source link

flag to opt out the Prometheus Listener of the global connection limit #6064

Open bcollard opened 2 years ago

bcollard commented 2 years ago

Version

No response

Is your feature request related to a problem? Please describe.

The goal is to limit the number of downstream connections while still allowing Prometheus to scrape metrics. The static Prometheus listener should have this flag as an option: ignore_global_conn_limit in charts/gloo/templates/9-gateway-proxy-configmap.yaml

Doc ref: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/listener/v3/listener.proto#envoy-v3-api-field-config-listener-v3-listener-ignore-global-conn-limit And https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/overload_manager/overload_manager#limiting-active-connections

I'm not sure if this same option is also required on the Admin listener, which is the final target in this case.

bcollard commented 2 years ago

requires Envoy 1.21

github-actions[bot] commented 3 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.