search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.07k stars 436 forks source link

defaultDashboardFolderId setting is not working for Grafana dashboards #6536

Closed jmunozro closed 8 months ago

jmunozro commented 2 years ago

Gloo Edge Version

1.11.x (latest stable)

Kubernetes Version

1.23.x

Describe the bug

defaultDashboardFolderId should be the location for ALL the grafana dashboards

Steps to reproduce the bug

helm repo add glooe https://storage.googleapis.com/gloo-ee-helm
helm repo update
helm upgrade --install gloo glooe/gloo-ee --namespace gloo-system \
  --create-namespace --version 1.11.17 --devel -f - <<EOF
license_key: xxx
gloo:
  settings:
    kubeResourceOverride:
      spec:
        observabilityOptions:
          grafanaIntegration:
            defaultDashboardFolderId: 29
EOF

You see that the dynamic upstream are created in the custom folder, but the static are created in the default:

image

Expected Behavior

I didn't find any way to workaround this issue

Additional Context

Related: #5853

nscherer-chipotle commented 1 year ago

Would love to see a fix for this one!

edubonifs commented 9 months ago

For one of our clients, when he tries to use this setting in order to move all dashboards to desired folderId, he only gets Envoy Statistic, Gloo Overview and Kubernetes Cluster Monitoring, so missing two.

I have observed that the resting, Extauth Dashboard and All Upstreams, aren't moved to the desired folder.

I managed to reproduce that by removing providers on glooe-grafana config map in Gloo-system:

apiVersion: v1
data:
  dashboardproviders.yaml: |
    apiVersion: 1
  datasources.yaml: |
    apiVersion: 1
    datasources:
    - access: proxy
      isDefault: true
      name: gloo
      type: prometheus
      url: http://glooe-prometheus-server:80
  grafana.ini: |
    [analytics]
    check_for_updates = true
    [grafana_net]
    url = https://grafana.net
    [log]
    mode = console
    [paths]
    data = /var/lib/grafana/
    logs = /var/log/grafana
    plugins = /var/lib/grafana/plugins
    provisioning = /etc/grafana/provisioning
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: gloo
    meta.helm.sh/release-namespace: gloo-system
  labels:
    app.kubernetes.io/instance: gloo
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: glooe-grafana
    app.kubernetes.io/version: 8.2.1
    helm.sh/chart: grafana-6.16.14
  name: glooe-grafana
  namespace: gloo-system
soloio-bot commented 8 months ago

Zendesk ticket #3039 has been linked to this issue.

davidjumani commented 7 months ago

This fix will be in v1.17.0-beta1, v1.16.1 and v1.15.12 when released