search

solo-io / gloo

The Cloud-Native API Gateway and AI Gateway
https://docs.solo.io/
Apache License 2.0
4.1k stars 446 forks source link

gloo validation hook rejects upstream deletion because linked service is already gone #6543

Open jdef opened 2 years ago

jdef commented 2 years ago

Gloo Edge Version

1.10.x

Kubernetes Version

1.21.x

Describe the bug

I delete a namespace that had a k8s service and a gloo upstream that referred to it. the service was deleted. the gloo validation hook rejected the deletion of the upstream, complaining that the service on which it depends was missing.

Steps to reproduce the bug

  1. create ns
  2. create service
  3. create upstream that refers to said service
  4. delete the ns - watch the delete hang
  5. list upstreams in the ns - observe they are still there
  6. delete the upstream manually - observe the validation hook rejecting the DELETE request (because the linked service is gone)

Expected Behavior

since i'm deleting an upstream, if the linked service is already gone i expect validation of the DELETE to succeed

Additional Context

No response

jdef commented 2 years ago

xref #2797

hengkuang777 commented 2 years ago

+1

sebastian-popa commented 2 years ago

+1

chrisgaun commented 2 years ago

Needs backporting to 1.11

github-actions[bot] commented 5 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.