solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.07k stars 435 forks source link

Testing support for Setup Syncer and Kube Factories #7256

Open jackstine opened 1 year ago

jackstine commented 1 year ago

Version

No response

Is your feature request related to a problem? Please describe.

Currently we have testing support for the Setup Syncer using in memory factories. It would be nice to also support testing for kube factories as well. This would provide real kubernetes testing support, without the full need for an e2e kube test or gloo. And it would also enable the use of debugging.

Describe the solution you'd like

Enabling a testing suite that uses Kube Factories, so that we can test Gloo using Kubernetes. This will aid support with solo-kit as well.

Describe alternatives you've considered

No response

Additional Context

No response

sam-heilbron commented 1 year ago

@jackstine could you clarify what specific tests you would like to see added?

Currently all of our regression tests run gloo in a k8s cluster. Perhaps we could expand one of those suites to test a behavior?

jackstine commented 1 year ago

I was more so just wanting to test the running and starting of the setup syncers with kube factories. There are a lot of go routines that can go off, and being about to walk through the debugger on these particular types of code would be useful in certain situations.

An alternative to this would be to ensure that we cover errors and log them appropriately. On one account this error was hard to find. I could see it in Gloo pod, but I had no idea where it was coming from.

I think running through the code could have save me valuable time.

The happy path tests, do not currently support kube factories.

github-actions[bot] commented 3 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.